Skip to content

Improved test coverage#29

Merged
Gerrit91 merged 9 commits intomainfrom
more-tests
Apr 21, 2026
Merged

Improved test coverage#29
Gerrit91 merged 9 commits intomainfrom
more-tests

Conversation

@AnnaSchreiner
Copy link
Copy Markdown
Contributor

Description

references #26

@AnnaSchreiner AnnaSchreiner requested a review from a team as a code owner April 8, 2026 11:19
@metal-robot metal-robot Bot added this to Development Apr 8, 2026
@majst01 majst01 requested a review from Gerrit91 April 8, 2026 13:47
Copy link
Copy Markdown
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I have a few comments. :)

Comment thread cmd/admin/v2/image.go Outdated
Comment thread tests/e2e/admin/image_test.go Outdated
Comment thread tests/e2e/admin/switch_test.go Outdated
Comment thread tests/e2e/admin/switch_test.go Outdated
Comment thread tests/e2e/api/audit_test.go Outdated
Comment thread tests/e2e/api/token_test.go Outdated
Comment thread tests/e2e/api/token_test.go
Comment thread tests/e2e/api/user_test.go
@Gerrit91
Copy link
Copy Markdown
Contributor

Is it ready for another review?

@AnnaSchreiner AnnaSchreiner requested a review from Gerrit91 April 16, 2026 06:19
@Gerrit91 Gerrit91 moved this to In Progress in Development Apr 20, 2026
Copy link
Copy Markdown
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting really close. Keen to merge it. :)

Comment thread tests/e2e/api/project_test.go Outdated
Comment thread tests/e2e/api/project_test.go
Comment thread tests/e2e/api/project_test.go Outdated
Comment thread tests/e2e/api/user_test.go Outdated
Copy link
Copy Markdown
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Image

@Gerrit91 Gerrit91 merged commit 34c7b42 into main Apr 21, 2026
5 checks passed
@Gerrit91 Gerrit91 deleted the more-tests branch April 21, 2026 11:01
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Development Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants